Update docker images and GHA to use miniforge #740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjspielman
approved these changes
Aug 30, 2024
|
|
||
| # Install conda-lock | ||
| RUN conda install --channel=conda-forge --name=base conda-lock | ||
| RUN conda install --channel=conda-forge --name=base conda-lock && conda clean --all --yes |
There was a problem hiding this comment.
just spacing
Suggested change
| RUN conda install --channel=conda-forge --name=base conda-lock && conda clean --all --yes | |
| RUN conda install --channel=conda-forge --name=base conda-lock \ | |
| && conda clean --all --yes |
jaclyn-taroni
approved these changes
Aug 30, 2024
This was referenced Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #711
Closes #713
In this PR, I changed the GitHub Actions for active modules and templates to use miniforge in place of miniconda.
I also updated the Docker images that use both conda and renv to be set up using miniforge (now mirroring the installation from the miniforge Docker image). I also updated the docs example for that instruction, but I did not do a larger docs update, as I will leave that for #712.
While I was in there, I cleaned a few little things in the Dockerfiles to make them more uniform.